iris/effectcraft
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: sync upstream (11 Commits) #13

Merged
alf merged 11 commits from chore/sync-upstream-20261028 into main 2026-10-28 06:23:55 +00:00
Conversation 0 Commits 11 Files changed 15 +685 -72
alf commented 2026-10-28 06:23:54 +00:00
Owner
Copy link

Upstream-Sync von upstream/main (11 Commits). Fast-Forward.

  • af415aa6 Merge pull request #2493 from Jeremy8776/feat/install-scope-policy
  • d0a67ac0 test(installer): cover the compiled folder searches, resolver chains and wizard folder replay
  • a63b3bc7 ci: use storytold/craft-common-actions at the merged installer-policy commit
  • 44061a3b fix(installer): check the exact architecture-specific machine folder
  • ca36861b fix(installer): resolve the wizard scope and folder correctly
  • f7f47233 docs(installer): say that silent installs are per-user and when the scope page appears
  • ed3e3d4b docs(installer): note that the 32-bit all-users folder is Program Files (x86); tidy wording
  • a41f75b4 docs(installer): describe the per-user default install location and scope
  • 28a8f3b0 fix(installer): harden install-policy checks and packaging-lint workflow
  • b110afb1 fix(installer): address scope and ARM64 review feedback
  • 4d5a56ed feat(installer): default to a per-user ArtCraft folder
Upstream-Sync von `upstream/main` (11 Commits). Fast-Forward. - af415aa6 Merge pull request #2493 from Jeremy8776/feat/install-scope-policy - d0a67ac0 test(installer): cover the compiled folder searches, resolver chains and wizard folder replay - a63b3bc7 ci: use storytold/craft-common-actions at the merged installer-policy commit - 44061a3b fix(installer): check the exact architecture-specific machine folder - ca36861b fix(installer): resolve the wizard scope and folder correctly - f7f47233 docs(installer): say that silent installs are per-user and when the scope page appears - ed3e3d4b docs(installer): note that the 32-bit all-users folder is Program Files (x86); tidy wording - a41f75b4 docs(installer): describe the per-user default install location and scope - 28a8f3b0 fix(installer): harden install-policy checks and packaging-lint workflow - b110afb1 fix(installer): address scope and ARM64 review feedback - 4d5a56ed feat(installer): default to a per-user ArtCraft folder
alf added 11 commits 2026-10-28 06:23:54 +00:00 
Real msiexec runs (per-user and all-users, silent and wizard) found two defects
that the metadata fixtures cannot see:

- "Only for me" published ALLUSERS=2, so FindRelatedProducts treated the run as
  per-machine and skipped the existing per-user copy. An interactive upgrade
  left two registered products and uninstall left files behind. The page now
  leaves ALLUSERS unset for a per-user choice.
- Windows Installer resolves Program Files once, for the context it started in,
  so choosing "Everyone" in the wizard installed into the user profile with a
  machine-wide registration. The wizard now sets the new-install folder itself
  after the choice (Program Files, Program Files (x86) for 32-bit, or the
  per-user Programs folder). Silent installs are unchanged.

check-install-policy.ps1 now fails if either regresses.
The pre-signing check matched any folder named Program Files, so it rejected
a valid MSI when Windows resolves Program Files elsewhere, accepted the 64-bit
root for an x86 package and accepted a different app name. Build the expected
folder from the package architecture's resolved root and the policy name.
The policy check now reads the compiled AppSearch and RegLocator rows for the
remembered-folder properties (registry root, key, value name and type for both
scopes) and runs the DIR, FOLDER, PATH and legacy exe actions in sequence order
against seeded values, so their precedence and the preset-folder guard cannot
regress. It also replays the wizard folder actions in sequence order (a
remembered folder beats the new-install default, a typed folder beats both) and
requires the machine restore action between the scope page and costing.
Merge pull request #2493 from Jeremy8776/feat/install-scope-policy
Some checks failed
ci.yml / Merge pull request #2493 from Jeremy8776/feat/install-scope-policy (pull_request) Failing after 0s
Details
packaging-lint.yml / Merge pull request #2493 from Jeremy8776/feat/install-scope-policy (pull_request) Failing after 0s
Details
sonarcloud.yml / Merge pull request #2493 from Jeremy8776/feat/install-scope-policy (pull_request) Failing after 0s
Details
ci.yml / Merge pull request #2493 from Jeremy8776/feat/install-scope-policy (push) Failing after 0s
Details
packaging-lint.yml / Merge pull request #2493 from Jeremy8776/feat/install-scope-policy (push) Failing after 0s
Details
sonarcloud.yml / Merge pull request #2493 from Jeremy8776/feat/install-scope-policy (push) Failing after 0s
Details
af415aa6e1
 
Windows installation policy: EffectCraft
alf merged commit af415aa6e1 into main 2026-10-28 06:23:55 +00:00
alf deleted branch chore/sync-upstream-20261028 2026-10-28 06:23:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
herkunft/alpha-feedback
Aus Rückmeldungen der Alpha-Tester

  
status
blockiert
 Wartet auf etwas anderes

  
status
zu-testen
 Gebaut, aber noch nicht im echten Einsatz geprüft

  
typ
bug
 Fehler

  
typ
docs
 Dokumentation

  
typ
enhancement
 Verbesserung einer vorhandenen Funktion

  
typ
feature
 Neue Funktion

  
typ
idea
 Idee, noch nicht entschieden

No labels
herkunft/alpha-feedback
status
blockiert
status
zu-testen
typ
bug
typ
docs
typ
enhancement
typ
feature
typ
idea
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
iris/effectcraft!13
No description provided.