iris/designcraft

Fork 0

chore: sync upstream (10 Commits) #13

Merged

alf merged 10 commits from chore/sync-upstream-20261028 into main

2026-10-28 06:23:50 +00:00

alf commented

2026-10-28 06:23:50 +00:00

Owner

Upstream-Sync von upstream/main (10 Commits). Fast-Forward.

2d8207ed Merge pull request #1896 from Jeremy8776/feat/install-scope-policy
eb25f8ad test(installer): cover the compiled folder searches, resolver chains and wizard folder replay
6ba87b1b ci: use storytold/craft-common-actions at the merged installer-policy commit
0b31b002 fix(installer): check the exact architecture-specific machine folder
d7e57d20 fix(installer): resolve the wizard scope and folder correctly
dfe52965 docs(installer): note that the 32-bit all-users folder is Program Files (x86); tidy wording
01328d16 docs(installer): describe the per-user default install location and scope
abe4847a fix(installer): harden install-policy checks and packaging-lint workflow
0d51fbd0 fix(installer): address scope and ARM64 review feedback
f4e05f4f feat(installer): default to a per-user ArtCraft folder

Upstream-Sync von `upstream/main` (10 Commits). Fast-Forward. - 2d8207ed Merge pull request #1896 from Jeremy8776/feat/install-scope-policy - eb25f8ad test(installer): cover the compiled folder searches, resolver chains and wizard folder replay - 6ba87b1b ci: use storytold/craft-common-actions at the merged installer-policy commit - 0b31b002 fix(installer): check the exact architecture-specific machine folder - d7e57d20 fix(installer): resolve the wizard scope and folder correctly - dfe52965 docs(installer): note that the 32-bit all-users folder is Program Files (x86); tidy wording - 01328d16 docs(installer): describe the per-user default install location and scope - abe4847a fix(installer): harden install-policy checks and packaging-lint workflow - 0d51fbd0 fix(installer): address scope and ARM64 review feedback - f4e05f4f feat(installer): default to a per-user ArtCraft folder

alf added 10 commits

2026-10-28 06:23:50 +00:00

feat(installer): default to a per-user ArtCraft folder f4e05f4f2d

fix(installer): address scope and ARM64 review feedback 0d51fbd0bb

fix(installer): harden install-policy checks and packaging-lint workflow abe4847a61

docs(installer): describe the per-user default install location and scope 01328d169a

docs(installer): note that the 32-bit all-users folder is Program Files (x86); tidy wording dfe5296522

fix(installer): resolve the wizard scope and folder correctly d7e57d2016

Real msiexec runs (per-user and all-users, silent and wizard) found two defects
that the metadata fixtures cannot see:

- "Only for me" published ALLUSERS=2, so FindRelatedProducts treated the run as
  per-machine and skipped the existing per-user copy. An interactive upgrade
  left two registered products and uninstall left files behind. The page now
  leaves ALLUSERS unset for a per-user choice.
- Windows Installer resolves Program Files once, for the context it started in,
  so choosing "Everyone" in the wizard installed into the user profile with a
  machine-wide registration. The wizard now sets the new-install folder itself
  after the choice (Program Files, Program Files (x86) for 32-bit, or the
  per-user Programs folder). Silent installs are unchanged.

check-install-policy.ps1 now fails if either regresses.

fix(installer): check the exact architecture-specific machine folder 0b31b002eb

The pre-signing check matched any folder named Program Files, so it rejected
a valid MSI when Windows resolves Program Files elsewhere, accepted the 64-bit
root for an x86 package and accepted a different app name. Build the expected
folder from the package architecture's resolved root and the policy name.

ci: use storytold/craft-common-actions at the merged installer-policy commit 6ba87b1b0c

test(installer): cover the compiled folder searches, resolver chains and wizard folder replay eb25f8ad96

The policy check now reads the compiled AppSearch and RegLocator rows for the
remembered-folder properties (registry root, key, value name and type for both
scopes) and runs the DIR, FOLDER, PATH and legacy exe actions in sequence order
against seeded values, so their precedence and the preset-folder guard cannot
regress. It also replays the wizard folder actions in sequence order (a
remembered folder beats the new-install default, a typed folder beats both) and
requires the machine restore action between the scope page and costing.

Merge pull request #1896 from Jeremy8776/feat/install-scope-policy

ci.yml / Merge pull request #1896 from Jeremy8776/feat/install-scope-policy (pull_request) Failing after 0s

Details

packaging-lint.yml / Merge pull request #1896 from Jeremy8776/feat/install-scope-policy (pull_request) Failing after 0s

Details

sonarcloud.yml / Merge pull request #1896 from Jeremy8776/feat/install-scope-policy (pull_request) Failing after 0s

Details

ci.yml / Merge pull request #1896 from Jeremy8776/feat/install-scope-policy (push) Failing after 0s

Details

packaging-lint.yml / Merge pull request #1896 from Jeremy8776/feat/install-scope-policy (push) Failing after 0s

Details

sonarcloud.yml / Merge pull request #1896 from Jeremy8776/feat/install-scope-policy (push) Failing after 0s

Details

2d8207ed3c

Windows installation policy: DesignCraft

alf merged commit 2d8207ed3c into main

2026-10-28 06:23:50 +00:00

alf deleted branch chore/sync-upstream-20261028

2026-10-28 06:23:50 +00:00

No reviewers

No labels

herkunft/alpha-feedback

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

iris/designcraft!13

No description provided.

Rows
Columns